This repository was archived by the owner on Jul 16, 2025. It is now read-only.
Closed
Conversation
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
thomasrockhu-codecov
previously approved these changes
May 1, 2025
Contributor
thomasrockhu-codecov
left a comment
There was a problem hiding this comment.
logic is sound
Comment on lines
83
to
84
| if branch and branch.startswith("gh-readonly-queue/"): | ||
| return branch.split("/")[1] |
Contributor
There was a problem hiding this comment.
for clarity can we do
Suggested change
| if branch and branch.startswith("gh-readonly-queue/"): | |
| return branch.split("/")[1] | |
| if branch: | |
| branch = branch.split("/")[1] if branch.startswith("gh-readonly-queue/") else branch | |
| return branch |
if we get a branch with gh-readonly-queue, it comes from a merge queue and the actual branch name is located in the middle
| return branch.split("/")[1] | ||
|
|
||
| branch = match.group(1) | ||
| return branch or None |
Contributor
There was a problem hiding this comment.
my worry here is if we depend on None to be meaningful versus ''. Previous logic doesn't account for empty string
thomasrockhu-codecov
previously approved these changes
May 1, 2025
Contributor
thomasrockhu-codecov
left a comment
There was a problem hiding this comment.
@joseph-sentry this looks good, can we move it to prevent-cli though?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if we get a branch with gh-readonly-queue, it comes from a merge queue and the actual branch name is located in the middle