Skip to content

fix: generate inputs for all route params in Debug Toolbar #9964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michalsn wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −5
Open

fix: generate inputs for all route params in Debug Toolbar #9964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions system/Debug/Toolbar/Views/toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ var ciDebugBar = {
var rowGet = this.toolbar.querySelectorAll(
'td[data-debugbar-route="GET"]'
);
var patt = /\((?:[^)(]+|\((?:[^)(]+|\([^)(]*\))*\))*\)/;
var patt = /\(.+?\)/g;

for (var i = 0; i < rowGet.length; i++) {
row = rowGet[i];
Expand All @@ -788,10 +788,9 @@ var ciDebugBar = {
'<form data-debugbar-route-tpl="' +
ciDebugBar.trimSlash(row.innerText.replace(patt, "?")) +
'">' +
row.innerText.replace(
patt,
'<input id="debugbar-route-id-' + i + '" type="text" placeholder="$1">'
) +
row.innerText.replace(patt, function (match) {
return '<input type="text" placeholder="' + match + '">';
}) +
'<input type="submit" value="Go" class="debug-bar-mleft4">' +
"</form>";
}
Expand Down
1 change: 1 addition & 0 deletions user_guide_src/source/changelogs/v4.7.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Bugs Fixed
- **Model:** Fixed a bug where ``BaseModel::updateBatch()`` threw an exception when ``updateOnlyChanged`` was ``true`` and the index field value did not change.
- **Session:** Fixed a bug in ``MemcachedHandler`` where the constructor incorrectly threw an exception when ``savePath`` was not empty.
- **Toolbar:** Fixed a bug where the standalone toolbar page loaded from ``?debugbar_time=...`` was not interactive.
- **Toolbar:** Fixed a bug in the Routes panel where only the first route parameter was converted to an input field on hover.
- **View:** Fixed a bug where ``View`` would throw an error if the ``appOverridesFolder`` config property was not defined.

See the repo's
Expand Down