Skip to content

fix: remove dependency on iphlpsvc #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spikecurtis merged 1 commit into from
Jan 16, 2026
Merged

fix: remove dependency on iphlpsvc #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Installer/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,10 @@ private static int BuildMsiPackage(MsiOptions opts)
RestartServiceDelayInSeconds = 30,
ResetPeriodInDays = 1,
PreShutdownDelay = 1000 * 60 * 3, // default
// This matches Tailscale's service dependencies.
// This matches Tailscale's service dependencies, with one omission: iphlpsvc. We do not
// use any of the IPv6 transition technologies provided by that service.
DependsOn =
[
new ServiceDependency("iphlpsvc"), // IP Helper
new ServiceDependency("netprofm"), // Network List Service
new ServiceDependency("WinHttpAutoProxySvc"), // WinHTTP Web Proxy Auto-Discovery Service
],
Expand Down
1 change: 1 addition & 0 deletions Tests.App/Services/SettingsManagerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using Coder.Desktop.App.Services;

namespace Coder.Desktop.Tests.App.Services;

[TestFixture]
public sealed class SettingsManagerTests
{
Expand Down
Loading