-
Notifications
You must be signed in to change notification settings - Fork 55
🤖 feat: secrets management in Settings → Projects #2139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ammar-agent
wants to merge
26
commits into
main
Choose a base branch
from
secrets-v4jd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+712
−279
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a7278a4
feat: add import secrets from another project in SecretsModal
ammar-agent 1cffb0b
fix: use functional state update in handleImportFromProject
ammar-agent 5a14713
refactor: move import dropdown to top row, add SecretsModal story
ammar-agent fcc6981
fix: disable Save button while import is in flight
ammar-agent 2de55e4
refactor: move secrets management into Settings → Projects section
ammar-agent d22102a
fix: cancel stale imports when project changes
ammar-agent 7bddc88
fix: reset isImporting when project changes
ammar-agent f237360
refactor: change secrets icon to settings icon
ammar-agent d74b6bc
fix: use Testing Library query instead of :has-text selector
ammar-agent 5e10412
fix: refresh projectSecretKeys after saving secrets
ammar-agent 699766a
fix: use useLayoutEffect for projectPath ref to avoid race
ammar-agent 26d82ba
fix: guard against empty projectPath in secrets section
ammar-agent 63029d9
fix: warn before switching projects with unsaved secrets
ammar-agent b257860
fix: prompt for unsaved secrets when deep-linking to project
ammar-agent 736e502
fix: avoid aria-label collision with global settings button
ammar-agent 7002d68
fix: handle MCP_TOKEN appearing in multiple inputs for storybook test
ammar-agent e5a5cd0
fix: improve robustness of secrets import test
ammar-agent 47e425d
fix: wrap import click in act() for better CI stability
ammar-agent fa84f7e
fix: use native select in tests for secrets import (happy-dom portal …
ammar-agent b0a85e0
tests: stabilize secrets import integration test
ammar-agent 7a26c83
tests: ensure import select value is set
ammar-agent 34b3764
tests: harden secrets import select handling
ammar-agent 38bb98a
tests: make secrets import selection more robust
ammar-agent 6d1992b
tests: expose secrets import helper for UI
ammar-agent e6bd2e5
tests: rely on secrets state helper for import
ammar-agent f8289c7
tests: persist imported secrets via state helper
ammar-agent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.