Add test coverage for CSRF-disabled scenarios #250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses missing test coverage for
csrfEnabled = falseconfiguration in CBWIREController, as identified in PR #238 review feedback.Changes
csrfEnabled = falsegenerateCSRFToken()returns empty string when CSRF is disabledBoth tests properly isolate settings changes to avoid test pollution.
it( "should process requests without CSRF verification when csrfEnabled = false", function() { var settings = getInstance( "coldbox:modulesettings:cbwire" ); settings.csrfEnabled = false; var payload = incomingRequest( csrfToken = "badToken" // Invalid token should not throw ); var response = cbwireController.handleRequest( payload, event ); expect( isStruct( response ) ).toBeTrue(); } );💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.