feat(commands)!: deprecate '-s' signoff parameter#1221
feat(commands)!: deprecate '-s' signoff parameter#1221AdrianDC wants to merge 7 commits intocommitizen-tools:v4from
Conversation
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.6.1 to 0.6.2. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.6.1...0.6.2) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
If 'always_signoff' is enabled in configurations, or '-s' is used alone on the CLI, the following errors arise due to 'git commit' argument failures : > signoff mechanic is deprecated, please use `cz commit -- -s` instead. > fatal: /tmp/...: '/tmp/... is outside repository at '...' Signed-off-by: Adrian DC <radian.dc@gmail.com>
Signed-off-by: Adrian DC <radian.dc@gmail.com>
Signed-off-by: Adrian DC <radian.dc@gmail.com>
Signed-off-by: Adrian DC <radian.dc@gmail.com>
…nd sources
Details: The git sources folder ownership may be detected as dubious if running
in a container with sources mounted to work on fixes and tests,
breaking 'test_find_git_project_root' and 'test_get_commits_with_signature'
> commitizen.exceptions.GitCommandError: fatal: detected dubious ownership in repository at '...'
---
Signed-off-by: Adrian DC <radian.dc@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4 #1221 +/- ##
=====================================
Coverage ? 97.61%
=====================================
Files ? 55
Lines ? 2515
Branches ? 0
=====================================
Hits ? 2455
Misses ? 60
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Adrian DC <radian.dc@gmail.com>
|
Though implemented per request towards v4, I vote against my own PR, |
I'm ok to keep a few exceptions. As long as the underlying logic is not duplicate and the document is suggesting using |
|
Deprecation of |
2 participants
Description
feat(commands)!: deprecate '-s' signoff parameter
Follow-up to #1206, deprecating -s for major v4.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context