feat: add parameter to changelog generation #1625
feat: add parameter to changelog generation #1625dornech wants to merge 3 commits intocommitizen-tools:masterfrom
Conversation
commitizen/commands/changelog.py
Outdated
| tree, | ||
| self.cz.template_loader, | ||
| self.template, | ||
| incremental=self.incremental |
There was a problem hiding this comment.
missing comma at the end of line.
There was a problem hiding this comment.
Ah sorry, I tested locally and did the change directly in GitHub ...
But thanks it is being considered at least for release 4.11, I think it is a simple change with real benefit for many.
|
It'd be better to add test cases related to #1620, thanks. |
fix of previous change/commit regarding same topic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
+ Coverage 97.33% 98.25% +0.91%
==========================================
Files 42 58 +16
Lines 2104 2694 +590
==========================================
+ Hits 2048 2647 +599
+ Misses 56 47 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi @dornech , can you help to improve the test coverage when you have a moment? Thanks! |
|
Hm. I am adfraid I am not experienced enough with pytest and etc to knpw what to do. |
|
It's ok 👌 |
|
Hi @dornech , I went through the discussion #1620 and our current codebase. You can refer to the tests with I can continue to work on for the test. The discussion is definitely great for those people who want a |
|
Here you go: You may refer to my repository https://github.com/dornech/the-hatchlor-enhanced/blob/main/%7B%7Bcookiecutter.project_slug%7D%7D/changelog_commitizen-template.md.j2 |
|
Thanks! Since I created another PR fixing the issue you reported, with test coverage, I am going to close this PR. |
... to identify incremental generation run in the jinja template.
This allows to include / exclude f. e. header lines form the current generation run to avoid multiple generation of header line(s)
Please refer to #1620