fix(bump): remove NotAllowed related to --get-next option, and other related refactoring#1644
Closed
bearomorphism wants to merge 1 commit intocommitizen-tools:v4-10-0from
Closed
fix(bump): remove NotAllowed related to --get-next option, and other related refactoring#1644bearomorphism wants to merge 1 commit intocommitizen-tools:v4-10-0from
NotAllowed related to --get-next option, and other related refactoring#1644bearomorphism wants to merge 1 commit intocommitizen-tools:v4-10-0from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4-10-1 #1644 +/- ##
==========================================
Coverage ? 98.64%
==========================================
Files ? 60
Lines ? 2651
Branches ? 0
==========================================
Hits ? 2615
Misses ? 36
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
55789cb to
b06e851
Compare
NotAllowed
NotAllowedNotAllowed related to --get-next option, and other related refactoring
b06e851 to
d7cabb5
Compare
d7cabb5 to
bed2c7f
Compare
bed2c7f to
35f0ce0
Compare
Member
|
ah... didn't notice this one. I thought I moved all the PRs out of |
Collaborator
Author
|
It's ok this was a very new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
dry_run = Truewhile we already haveget_next = True. The latter condition raises aGetNextExit()exception in the original code, so no effect if we setdry_runtoTrue. Moreover, the original code isself.dry_run = Truewhich is ineffective since we never use the member variable.get_nexttonext_version_to_stdout. The variable nameget_nextis very unclear and hard to guess what it will do. I think we can consider renaming the option in the next major release.--get-nextwhen changelog is enabled #1640) ReplaceNotAllowedrelated to--get-nextoption with warnings.GetNextExitexception because we already haveDryRunExit.--get-nextis just--dry-runbut doing less things IMO.