test: replace try with pytest.raises#1654
test: replace try with pytest.raises#1654bearomorphism merged 1 commit intocommitizen-tools:v4-10-1from
Conversation
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-10-1 #1654 +/- ##
==========================================
Coverage ? 98.67%
==========================================
Files ? 60
Lines ? 2647
Branches ? 0
==========================================
Hits ? 2612
Misses ? 35
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/test_git.py
Outdated
| @@ -111,11 +112,8 @@ def test_git_message_with_empty_body(): | |||
| @pytest.mark.usefixtures("tmp_commitizen_project") | |||
| def test_get_log_as_str_list_empty(): | |||
| """ensure an exception or empty list in an empty project""" | |||
There was a problem hiding this comment.
Not sure why there are more than one possible behavior in the original test code. That's strange.
There was a problem hiding this comment.
Took a look at the history. Looks like it varies based on the git version.
There was a problem hiding this comment.
We probably need to take a look at which git version changed this
There was a problem hiding this comment.
We can either revert this test or add a skipif based on git version. We can merge this one after one of these two actions has been done. Thanks!
There was a problem hiding this comment.
will revert later
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Except for the empty list /exception one, we're good to merge
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
bearomorphism
force-pushed
the
try-test
branch
from
810d10d to
548467c
Compare
bearomorphism
force-pushed
the
try-test
branch
from
548467c to
90b8bc6
Compare
|
ok now it is ready to be merged. |
2 participants
No description provided.