Skip to content

Conversation

@jairhenrique
Copy link
Contributor

@jairhenrique jairhenrique commented Oct 22, 2025

Describe the purpose of your pull request

  • Provide a clear and concise description of the changes.

Related issues (only if applicable)

  • Provide links to issues relating to this pull request.

How to test? (only if applicable)

  • What part of the application was affected by the changes? What should be tested?

Security (only if applicable)

  • Describe any potential risks that could affect the component in terms of security.

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@jairhenrique jairhenrique requested a review from a team as a code owner October 22, 2025 16:51
@laliconfigcat
Copy link
Member

Hello @jairhenrique ,

Thanks for your contribution. Could you please read the contribution agreement and check the "I have read and accepted the contribution agreement." checkbox in the pull request's description?

@jairhenrique
Copy link
Contributor Author

Hello @jairhenrique ,

Thanks for your contribution. Could you please read the contribution agreement and check the "I have read and accepted the contribution agreement." checkbox in the pull request's description?

Hi @laliconfigcat! Done!

@jairhenrique jairhenrique force-pushed the py314 branch 2 times, most recently from 28d7cb3 to bc1c66c Compare October 22, 2025 20:17
@jairhenrique
Copy link
Contributor Author

@laliconfigcat I can't reproduce this failed tests.

@laliconfigcat
Copy link
Member

Hello @jairhenrique ,

We'll check what is wrong with the tests next week.

@kp-cat
Copy link
Member

kp-cat commented Nov 13, 2025

Hey @jairhenrique,

Thanks for the contribution.
Could you please update your fork? I fixed the test in #72

@sonarqubecloud
Copy link

@jairhenrique
Copy link
Contributor Author

@kp-cat rebase done!

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.94%. Comparing base (95e1f9f) to head (4631276).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          23       23           
  Lines        1569     1569           
=======================================
  Hits         1521     1521           
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kp-cat kp-cat merged commit 2c3e339 into configcat:master Nov 14, 2025
245 of 252 checks passed
@jairhenrique jairhenrique deleted the py314 branch November 14, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants