Fix key export for non-CRT RSA keys and add Ed25519 PEM support #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes connectbot/connectbot#1812
This PR fixes SSH key export failures that occur when using security providers like Conscrypt, which return RSAPrivateKey impleme
ntations that don't implement RSAPrivateCrtKey (e.g., OpenSSLRSAPrivateKey). It also adds Ed25519 support to PEMEncoder.
Problem
When using the OSS build of ConnectBot (which uses Conscrypt's OpenSSL provider), exporting RSA keys fails with "Unsupported key
type" error because:
Additionally, Ed25519 keys could not be exported in PEM format.
Solution
Changes
Testing
🤖 Generated with Claude Code