added pgpm dump #573
Merged
added pgpm dump #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyramation
reviewed
Jan 7, 2026
pgpm/cli/src/commands/dump.ts
Outdated
|
|
||
| function quoteIdent(s: string): string { | ||
| return `"${String(s).replace(/"/g, '""')}"`; | ||
| } |
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
pyramation
reviewed
Jan 7, 2026
pgpm/cli/src/commands/dump.ts
Outdated
|
|
||
| function quoteIdent(s: string): string { | ||
| return `"${String(s).replace(/"/g, '""')}"`; | ||
| } |
Contributor
There was a problem hiding this comment.
pgpm/cli/src/commands/dump.ts
Outdated
|
|
||
| function quoteIdent(s: string): string { | ||
| return `"${String(s).replace(/"/g, '""')}"`; | ||
| } |
Contributor
There was a problem hiding this comment.
pgpm/cli/src/commands/dump.ts
Outdated
| return `"${String(s).replace(/"/g, '""')}"`; | ||
| } | ||
|
|
||
| async function runPgDump(args: string[], env: Record<string, string>): Promise<void> { |
Contributor
There was a problem hiding this comment.
constructive/pgpm/cli/src/commands/deploy.ts
Lines 7 to 10 in cb086f0
pgpm/cli/src/commands/dump.ts
Outdated
| await new Promise<void>((resolve, reject) => { | ||
| const child = spawn('pg_dump', args, { | ||
| env: { | ||
| ...process.env, |
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
constructive/postgres/pg-env/src/env.ts
Line 43 in cb086f0
pgpm/cli/src/commands/dump.ts
Outdated
|
|
||
| if (databaseIdInfo) { | ||
| const pruneSql = await buildPruneSql(dbname, databaseIdInfo.id); | ||
| fs.appendFileSync(outPath, pruneSql, 'utf8'); |
Jovonni
commented
Jan 7, 2026
| } | ||
|
|
||
| async function runPgDump(args: string[], env: Record<string, string>): Promise<void> { | ||
| async function runPgDump(args: string[], env: NodeJS.ProcessEnv): Promise<void> { |
Contributor
Author
There was a problem hiding this comment.
using the lib you said, much cleaner @pyramation
Jovonni
commented
Jan 7, 2026
| const table = String(row.table_name); | ||
| lines.push(`delete from ${quoteIdent(schema)}.${quoteIdent(table)} where database_id <> '${databaseId}';`); | ||
| // Use QuoteUtils for robust identifier quoting | ||
| const qualified = QuoteUtils.quoteQualifiedIdentifier(schema, table); |
Jovonni
commented
Jan 7, 2026
| const pruneSql = await buildPruneSql(dbname, databaseIdInfo.id); | ||
| fs.appendFileSync(outPath, pruneSql, 'utf8'); | ||
| // Use writeFileSync with 'a' flag for explicit append as requested | ||
| fs.writeFileSync(outPath, pruneSql, { encoding: 'utf8', flag: 'a' }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here we add
pgpm dumpusage
dump a postgres database to a sql file
pgpm dumptarget postgres database name
pgpm dump --database <db_name>alias for --database
pgpm dump --db <db_name>output file path
pgpm dump --database <db_name> --out <path/to/file.sql>include a prune step that keeps only this database_id after restore
pgpm dump --database <db_name> --database-id <uuid>working directory (default: current directory)
pgpm dump --cwd <path/to/dir>show this help message
pgpm dump --helpcc @pyramation @Anmol1696