feat(create-gen-app): add useBoilerplatesConfig option to control .boilerplates.json resolution #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilerplates.json resolution Add a new option `useBoilerplatesConfig` to both `ScaffoldOptions` and `InspectOptions`: - When true (default), if fromPath doesn't exist directly, the resolver will check .boilerplates.json for a base directory to prepend - When false, .boilerplates.json is ignored and fromPath is used as-is This allows callers to explicitly bypass .boilerplates.json resolution when they want to use a specific directory path without fallback behavior.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(create-gen-app): add useBoilerplatesConfig option
Summary
Adds a new
useBoilerplatesConfigoption to bothScaffoldOptionsandInspectOptionsinterfaces. This option controls whether the.boilerplates.jsonfallback resolution is used when resolvingfromPath.true(default): existing behavior - iffromPathdoesn't exist directly, check.boilerplates.jsonfor a base directory to prependfalse: skip.boilerplates.jsonlookup entirely and usefromPathas-isThis enables callers (like
@pgpmjs/core) to explicitly bypass.boilerplates.jsonresolution when they want to use a specific directory path without fallback behavior, eliminating the need for brittle post-hoc validation.Review & Testing Checklist for Human
trueshould maintain existing behavior for all current consumersuseBoilerplatesConfig: falseactually bypasses.boilerplates.jsonlookup (no unit tests were added)inspect(),scaffold(), and their internal methodsNotes
This is part of a larger refactoring to move resolution policy control from
@pgpmjs/coreintocreate-gen-appfor cleaner architecture. A follow-up PR will update@pgpmjs/coreto use this new option.Link to Devin run: https://app.devin.ai/sessions/36e9a9f44158421996d176f2ce90d280
Requested by: Dan Lynch (@pyramation)