fix(plpgsql-deparser): fix 2 more failing fixtures (189/190 now pass) #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(plpgsql-deparser): fix 2 more failing fixtures (189/190 now pass)
Summary
This PR fixes 2 of the 3 remaining failing round-trip test fixtures, bringing the pass rate from 187/190 to 189/190.
Fixes:
cursor_name CURSOR FOR queryinstead ofcursor_name refcursor CURSOR FOR query(fixesplpgsql_transaction-17.sql)plpgsql_control-15.sql)$tag$delimiters, not just$$lbl.ain FOR loopsRemaining failure:
plpgsql_varprops-13.sql- nested DECLARE inside FOR loop (variables are hoisted to top-level DECLARE, changing semantics)Review & Testing Checklist for Human
skipLabelparameter doesn't affect nested blocks that should still have their own labelsTest Plan
Verify output shows "Round-trip tested 189 of 190 fixtures (1 known failures skipped)"
Notes
escapedTagvariable inextractBodyFromSqlis computed but not used - this is harmless dead code