Conversation
When an MCP UI app can't handle a tool's data (e.g. server tags non-UI tools with ui/resourceUri), hide the UI rather than showing confusing error messages. Changes: - Return null on error instead of rendering red error box - Wrap sendToolInput/sendToolResult in try/catch - Hide UI when MCP app reports error/critical via bridge logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendToolInputandsendToolResultbridge calls in try/catch so failures hide the UI gracefullyContext
MCP servers may set
_meta.ui.resourceUrion tools where the UI app can't actually handle that tool's data. The detection of whether a tool has UI is correct (we trust the server's metadata), but we need to be resilient when the UI app can't render.Test plan
Summary by cubic
Silently hide the MCP UI when the embedded app errors, instead of showing confusing error boxes. This makes incompatible tool UIs fail closed while keeping functional UIs unaffected.
Written for commit fdede37. Summary will update on new commits.