fix: load config in project with no dirs#10737
Open
uinstinct wants to merge 1 commit intocontinuedev:mainfrom
Open
fix: load config in project with no dirs#10737uinstinct wants to merge 1 commit intocontinuedev:mainfrom
uinstinct wants to merge 1 commit intocontinuedev:mainfrom
Conversation
|
Want AI-powered code review for this PR? Get instant analysis, interactive visualizations, and actionable insights. |
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="core/config/ConfigHandler.ts">
<violation number="1" location="core/config/ConfigHandler.ts:595">
P1: Deadlock: getSerializedConfig awaits isInitialized but when currentProfile is null, reloadConfig returns early without emitting the "init" event, causing isInitialized to never resolve. This will hang callers on projects without profiles/directories.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wait for cascadeInit to finish before getting the serialized config. This previously created a race condition where the current profile and config were still null and not loaded.
Also in ParallelListeners, do not update config till configLoadInterrupted returns true.
resolves CON-5299
closes #9587
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Continue Tasks: ❌ 7 failed — View all
Summary by cubic
Fix a config loading race in projects without directories by waiting for initialization before reading the serialized config and skipping updates when the load is interrupted (CON-5299).
Written for commit 409a945. Summary will update on new commits.