Skip to content

Comments

fix: load config in project with no dirs#10737

Open
uinstinct wants to merge 1 commit intocontinuedev:mainfrom
uinstinct:config-no-dir
Open

fix: load config in project with no dirs#10737
uinstinct wants to merge 1 commit intocontinuedev:mainfrom
uinstinct:config-no-dir

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Feb 23, 2026

Description

Wait for cascadeInit to finish before getting the serialized config. This previously created a race condition where the current profile and config were still null and not loaded.

Also in ParallelListeners, do not update config till configLoadInterrupted returns true.

resolves CON-5299
closes #9587

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Continue Tasks: ❌ 7 failed — View all


Summary by cubic

Fix a config loading race in projects without directories by waiting for initialization before reading the serialized config and skipping updates when the load is interrupted (CON-5299).

  • Bug Fixes
    • ConfigHandler: await initialization before returning serialized config to avoid null profile/config.
    • ParallelListeners: do not update config when configLoadInterrupted is true.

Written for commit 409a945. Summary will update on new commits.

@uinstinct uinstinct requested a review from a team as a code owner February 23, 2026 07:40
@uinstinct uinstinct requested review from sestinj and removed request for a team February 23, 2026 07:40
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 23, 2026
@haystack-code-reviewer-pr-hook

Try Haystack Code Reviewer

Want AI-powered code review for this PR? Get instant analysis, interactive visualizations, and actionable insights.

Review this PR with Haystack

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="core/config/ConfigHandler.ts">

<violation number="1" location="core/config/ConfigHandler.ts:595">
P1: Deadlock: getSerializedConfig awaits isInitialized but when currentProfile is null, reloadConfig returns early without emitting the "init" event, causing isInitialized to never resolve. This will hang callers on projects without profiles/directories.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Local Default config.yaml is not loaded on start when there is not at least one directory in the project.

1 participant