*edit - sort callback usage

[xsuchy09]

I think that this is better implementation for user sorting function for this data source. Or not?

[xsuchy09]

Similar change for Nette 2.4 ...
v1.1.1...xsuchy09:v1.1.2

[paveljanda]

Can you please describe what is the difference in usage? Thanks

[xsuchy09]

See your email ... I wrote you 1st November ... but basic is that I think that this code is better for use. I don't see any reason why to deal with whole SQL when I want to change just ordering.

[xsuchy09]

Only one drawback - it is not possible to sort by multiple columns at once. Maybe I just need a demonstration of the use of the current implementation of user sorting.

[xsuchy09]

It can be easy solved with change in QueryHelper::orderBy method:

	public function orderBy($column, $order)
	{
		if (false === array_key_exists('ORDER', $this->query)) {
			$this->query['ORDER'] = [];
		}
		$this->query['ORDER'][] = [
			'expr_type' => 'colref',
			'base_expr' => $column,
			'no_quotes' => [
				'delim' => FALSE,
				'parts' => [$column]
			],
			'subtree'   => FALSE,
			'direction' => $order
		];

		return $this->sqlCreator->create($this->query);
	}