11 adapt to reference implementation by alexbalakirev · Pull Request #12 · corbado/corbado-python

alexbalakirev · 2024-10-27T14:37:35Z

@corbadoman Ready for review. To make a deployment for the new version I need CORBADO_FRONTEND_API secret. After that I could update the example applications if needed.

…ion service

…ate key

corbadoman · 2024-10-28T05:55:15Z

.github/workflows/python-package.yml

@@ -49,8 +49,10 @@ jobs:
        tox run
      env:
        CORBADO_BACKEND_API: ${{ vars.CORBADO_BACKEND_API }}


please the following order: project id, api secret, frontend api, backend api

corbadoman · 2024-10-28T05:55:46Z

src/corbado_python_sdk/config.py

-        backend_api (str): The base URL for the backend API. Defaults to "https://backendapi.cloud.corbado.io/v2".
-        short_session_cookie_name (str): The name of the cookie for short session management. Defaults to "cbo_short_session".
+        backend_api (str): The base URL for the backend API.
+        frontend_api (str): The base URL for the frontend API.


frontend api before backend api

corbadoman · 2024-10-28T05:56:16Z

src/corbado_python_sdk/config.py

-        short_session_cookie_name (str): The name of the cookie for short session management. Defaults to "cbo_short_session".
+        backend_api (str): The base URL for the backend API.
+        frontend_api (str): The base URL for the frontend API.
+        session_token_cookie_name (str): The name of the cookie for short session management. Defaults to "cbo_session_token".


we can remove this, we should not need that anymore

corbadoman · 2024-10-28T06:02:24Z

src/corbado_python_sdk/corbado_sdk.py

        if not self._sessions:
            self._sessions = SessionService(
-                short_session_cookie_name=self.config.short_session_cookie_name,
+                session_token_cookie_name=self.config.session_token_cookie_name,


remove this

corbadoman · 2024-10-28T06:10:06Z

src/corbado_python_sdk/exceptions/token_validation_exception.py

+        ISSUER_MISSMATCH (str): Indicates that the token issuer does not match the expected issuer.
+    """
+
+    INVALID_TOKEN = "Invalid token"  # noqa s105


shouldnot we have the following codes like in go:

CodeJWTGeneral Code = iota
CodeJWTIssuerMismatch
CodeJWTInvalidData
CodeJWTInvalidSignature
CodeJWTBefore
CodeJWTExpired
CodeJWTIssuerEmpty

Done, but due to different JWT implementation in Java and Python and error handling not all abovementioned error may get caught.

lukaskratzel · 2025-01-11T12:48:38Z

@alexbalakirev How can I use this version in my test project? Did you release it under some pre-release tag?

alexbalakirev · 2025-01-12T12:19:47Z

@alexbalakirev How can I use this version in my test project? Did you release it under some pre-release tag?

@lukaskratzel You can use/install this branch locally. Since this PR is not merged/reviewed, I have not deployed this version on PyPI. This branch has version 2.0.0 (as in VERSION file). You can use following command to install local version of the project (in this case SDK):
python -m pip install -e "path/to/sdk/project/root
Make sure your requirements.txt from example project has dependency on: passkeys >= 2.0.0

src/corbado_python_sdk/services/implementation/session_service.py

README.md

lukaskratzel · 2025-01-23T12:19:46Z

@alexbalakirev Are you working on this right now?

alexbalakirev · 2025-01-23T12:31:49Z

@alexbalakirev Are you working on this right now?

I am reviewing your changes and added CI/CD test to run on this branch too, so we can validate the correctness of the changes. You can text me on Slack to talk about non-code or organizational related topics.

src/corbado_python_sdk/services/implementation/session_service.py

…ectations

local/backend_api_public_v2.yml

scripts/generate-openapi.sh

src/corbado_python_sdk/services/implementation/session_service.py

alexbalakirev added 9 commits October 26, 2024 21:32

Add FAPI URL and BAPI URL to config.

a5e0ac1

Adapt issuer validation

541d81b

Rename short-term session to session-token

15d5b4a

Bump release version to 2.0.0

e9709c0

Rename get_and_validate_short_session_value to validate_token

4472ab8

Change validate_token error handling, add new exception type for sess…

c8b0c68

…ion service

Adapt existing token validation tests to new error handling

8f8d625

Add new tests to session service for issuer validation and false priv…

0e3e17c

…ate key

Add new test for issuer validation in session service

338ede3

alexbalakirev requested a review from corbadoman October 27, 2024 14:37

alexbalakirev self-assigned this Oct 27, 2024

alexbalakirev linked an issue Oct 27, 2024 that may be closed by this pull request

Adapt to reference implementation #11

Closed

10 tasks

Update README.md

96372a4

corbadoman reviewed Oct 28, 2024

View reviewed changes

alexbalakirev added 4 commits November 3, 2024 21:56

Remove session_token_cookie_name

112dc08

Reorder required fields for configuration

58000a8

Improved exception handling, renamed error codes

826c295

Change CORBADO_FRONTEND_API from variable to secret

21caa9a

lukaskratzel requested changes Jan 23, 2025

View reviewed changes

src/corbado_python_sdk/services/implementation/session_service.py Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

lukaskratzel added 4 commits January 23, 2025 10:09

reduce public fields of session service

cc785d8

update session token validation example

9dcaa43

adjust workflow to use var instead of secret

edd1586

return to public fields to make pydantic happy

43de3c2

lukaskratzel force-pushed the 11-adapt-to-reference-implementation branch from 454f0ea to 43de3c2 Compare January 23, 2025 11:16

alexbalakirev and others added 4 commits January 23, 2025 13:06

Enable CI/CD on changes on merge request

5be424d

Increase maximum line length on linting

612f4c7

Run CI/CD on Github Issue naming pattern

8c7fcbe

satisfy mypy

db9f228

update generated client and openapi specs

d372b3d

corbadoman reviewed Jan 23, 2025

View reviewed changes

src/corbado_python_sdk/services/implementation/session_service.py Outdated Show resolved Hide resolved

lukaskratzel added 2 commits January 23, 2025 14:21

enforce no trailing slashes in config urls

e99adda

remove last_session_token_validation_result from session_service.py

73a73ad

corbadoman approved these changes Jan 23, 2025

View reviewed changes

lukaskratzel added 4 commits January 23, 2025 14:32

satisfy flake8

f842777

remove all usages of _set_validation_error

2834573

adjust test_set_cname_expect_issuer_changed to new url validation exp…

ccddb45

…ectations

satisfy mypy

3ede93c

alexbalakirev commented Jan 23, 2025

View reviewed changes

local/backend_api_public_v2.yml Outdated Show resolved Hide resolved

scripts/generate-openapi.sh Show resolved Hide resolved

src/corbado_python_sdk/services/implementation/session_service.py Outdated Show resolved Hide resolved

remove unnecessary file

fe9f6cc

lukaskratzel merged commit 9b7a678 into main Jan 23, 2025
7 checks passed

Conversation

alexbalakirev commented Oct 27, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukaskratzel commented Jan 11, 2025

Uh oh!

alexbalakirev commented Jan 12, 2025

Uh oh!

Uh oh!

Uh oh!

lukaskratzel commented Jan 23, 2025

Uh oh!

alexbalakirev commented Jan 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants