-
Notifications
You must be signed in to change notification settings - Fork 18
Add separation design doc and reorganize doc navigation #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0723cea
72c2ad5
0478917
9a68691
8d7a48c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
|
|
||
| @ECHO ON | ||
| setlocal enabledelayedexpansion | ||
|
|
||
| set TRAVIS_OS_NAME=windows | ||
|
|
||
| IF "!DRONE_BRANCH!" == "" ( | ||
| for /F %%i in ("!GITHUB_REF!") do @set TRAVIS_BRANCH=%%~nxi | ||
| ) else ( | ||
| SET TRAVIS_BRANCH=!DRONE_BRANCH! | ||
| ) | ||
|
|
||
| if "%DRONE_JOB_BUILDTYPE%" == "boost" ( | ||
|
|
||
| echo "Running boost job" | ||
| echo '==================================> INSTALL' | ||
| REM there seems to be some problem with b2 bootstrap on Windows | ||
| REM when CXX env variable is set | ||
| SET "CXX=" | ||
|
|
||
| git clone https://github.com/boostorg/boost-ci.git boost-ci-cloned --depth 1 | ||
| cp -prf boost-ci-cloned/ci . | ||
| rm -rf boost-ci-cloned | ||
| REM source ci/travis/install.sh | ||
| REM The contents of install.sh below: | ||
|
|
||
| for /F %%i in ("%DRONE_REPO%") do @set SELF=%%~nxi | ||
| SET BOOST_CI_TARGET_BRANCH=!TRAVIS_BRANCH! | ||
| SET BOOST_CI_SRC_FOLDER=%cd% | ||
| if "%BOOST_BRANCH%" == "" ( | ||
| SET BOOST_BRANCH=develop | ||
| if "%BOOST_CI_TARGET_BRANCH%" == "master" set BOOST_BRANCH=master | ||
| ) | ||
|
|
||
| call ci\common_install.bat | ||
|
|
||
| echo '==================================> ZLIB' | ||
| git clone --branch v1.2.13 https://github.com/madler/zlib.git !BOOST_ROOT!\zlib-src --depth 1 | ||
| set ZLIB_SOURCE=!BOOST_ROOT!\zlib-src | ||
|
|
||
| echo '==================================> COMPILE' | ||
|
|
||
| REM set B2_TARGETS=libs/!SELF!/test libs/!SELF!/example | ||
| set B2_TARGETS=libs/!SELF!/test | ||
| call !BOOST_ROOT!\libs\!SELF!\ci\build.bat | ||
|
|
||
| ) | ||
|
Comment on lines
+1
to
+47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unix line endings (LF) in a The Windows batch parser has known issues with LF-only line endings, including label parsing failures at 512-byte boundaries. This file must use CRLF line endings. Consider adding a 🧰 Tools🪛 Blinter (1.0.112)[error] 1-1: Unix line endings detected. Explanation: Batch file uses Unix line endings (LF-only) which can cause GOTO/CALL label parsing failures and script malfunction due to Windows batch parser 512-byte boundary bugs. Recommendation: Convert file to Windows line endings (CRLF). Use tools like dos2unix, notepad++, or configure git with 'git config core.autocrlf true'. Context: File uses Unix line endings (LF-only) - 47 LF sequences found (E018) [error] 10-10: Unsafe SET command usage. Explanation: SET commands without proper validation or quoting can cause security issues. Recommendation: Always quote SET values and validate input: SET "var=safe value". Context: SET command value should be quoted for safety (SEC002) 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Copyright 2020 Rene Rivera, Sam Darwin | ||
| # Distributed under the Boost Software License, Version 1.0. | ||
| # (See accompanying file LICENSE.txt or copy at http://boost.org/LICENSE_1_0.txt) | ||
|
|
||
| set -xe | ||
|
|
||
| export DRONE_BUILD_DIR=$(pwd) | ||
| export VCS_COMMIT_ID=$DRONE_COMMIT | ||
| export GIT_COMMIT=$DRONE_COMMIT | ||
| export REPO_NAME=$DRONE_REPO | ||
| export USER=$(whoami) | ||
| export CC=${CC:-gcc} | ||
| export PATH=~/.local/bin:/usr/local/bin:$PATH | ||
| export TRAVIS_BUILD_DIR=$(pwd) | ||
| export TRAVIS_BRANCH=$DRONE_BRANCH | ||
| export TRAVIS_EVENT_TYPE=$DRONE_BUILD_EVENT | ||
|
|
||
| common_install () { | ||
| if [ -z "$SELF" ]; then | ||
| export SELF=`basename $REPO_NAME` | ||
| fi | ||
|
|
||
| git clone https://github.com/boostorg/boost-ci.git boost-ci-cloned --depth 1 | ||
| [ "$SELF" == "boost-ci" ] || cp -prf boost-ci-cloned/ci . | ||
| rm -rf boost-ci-cloned | ||
|
|
||
| if [ "$TRAVIS_OS_NAME" == "osx" ]; then | ||
| unset -f cd | ||
| fi | ||
|
|
||
| export BOOST_CI_TARGET_BRANCH="$TRAVIS_BRANCH" | ||
| export BOOST_CI_SRC_FOLDER=$(pwd) | ||
|
|
||
| . ./ci/common_install.sh | ||
| } | ||
|
|
||
| if [[ $(uname) == "Linux" && "$B2_ASAN" == "1" ]]; then | ||
| echo 0 | sudo tee /proc/sys/kernel/randomize_va_space > /dev/null | ||
| fi | ||
|
|
||
| if [ "$DRONE_JOB_BUILDTYPE" == "boost" ]; then | ||
|
|
||
| echo '==================================> INSTALL' | ||
|
|
||
| common_install | ||
|
|
||
| echo '==================================> SCRIPT' | ||
|
|
||
| . $BOOST_ROOT/libs/$SELF/ci/build.sh | ||
|
|
||
| elif [ "$DRONE_JOB_BUILDTYPE" == "codecov" ]; then | ||
|
|
||
| echo '==================================> INSTALL' | ||
|
|
||
| common_install | ||
|
|
||
| echo '==================================> SCRIPT' | ||
|
|
||
| cd $BOOST_ROOT/libs/$SELF | ||
| ci/travis/codecov.sh | ||
|
|
||
| elif [ "$DRONE_JOB_BUILDTYPE" == "valgrind" ]; then | ||
|
|
||
| echo '==================================> INSTALL' | ||
|
|
||
| common_install | ||
|
|
||
| echo '==================================> SCRIPT' | ||
|
|
||
| cd $BOOST_ROOT/libs/$SELF | ||
| ci/travis/valgrind.sh | ||
|
|
||
| elif [ "$DRONE_JOB_BUILDTYPE" == "coverity" ]; then | ||
|
|
||
| echo '==================================> INSTALL' | ||
|
|
||
| common_install | ||
|
|
||
| echo '==================================> SCRIPT' | ||
|
|
||
| if [ -n "${COVERITY_SCAN_NOTIFICATION_EMAIL}" -a \( "$TRAVIS_BRANCH" = "develop" -o "$TRAVIS_BRANCH" = "master" \) -a \( "$DRONE_BUILD_EVENT" = "push" -o "$DRONE_BUILD_EVENT" = "cron" \) ] ; then | ||
| cd $BOOST_ROOT/libs/$SELF | ||
| ci/travis/coverity.sh | ||
| fi | ||
|
|
||
| elif [ "$DRONE_JOB_BUILDTYPE" == "cmake1" ]; then | ||
|
|
||
| set -xe | ||
|
|
||
| echo '==================================> INSTALL' | ||
|
|
||
| # already in the image | ||
| # pip install --user cmake | ||
|
|
||
| echo '==================================> SCRIPT' | ||
|
|
||
| export SELF=`basename $REPO_NAME` | ||
| BOOST_BRANCH=develop && [ "$DRONE_BRANCH" == "master" ] && BOOST_BRANCH=master || true | ||
| echo BOOST_BRANCH: $BOOST_BRANCH | ||
| cd .. | ||
| git clone -b $BOOST_BRANCH --depth 1 https://github.com/boostorg/boost.git boost-root | ||
| cd boost-root | ||
|
|
||
| mkdir -p libs/$SELF | ||
| cp -r $DRONE_BUILD_DIR/* libs/$SELF | ||
| # git submodule update --init tools/boostdep | ||
| git submodule update --init --recursive | ||
|
|
||
| cd libs/$SELF | ||
| mkdir __build__ && cd __build__ | ||
| cmake -DCMAKE_INSTALL_PREFIX=~/.local .. | ||
| cmake --build . --target install | ||
|
|
||
| elif [ "$DRONE_JOB_BUILDTYPE" == "cmake-superproject" ]; then | ||
|
|
||
| echo '==================================> INSTALL' | ||
|
|
||
| common_install | ||
|
|
||
| echo '==================================> COMPILE' | ||
|
|
||
| # Warnings as errors -Werror not building. Remove for now: | ||
| # export CXXFLAGS="-Wall -Wextra -Werror" | ||
| export CXXFLAGS="-Wall -Wextra" | ||
| export CMAKE_OPTIONS=${CMAKE_OPTIONS:--DBUILD_TESTING=ON} | ||
| export CMAKE_SHARED_LIBS=${CMAKE_SHARED_LIBS:-1} | ||
|
|
||
| mkdir __build_static | ||
| cd __build_static | ||
| cmake -DBOOST_ENABLE_CMAKE=1 -DBoost_VERBOSE=1 ${CMAKE_OPTIONS} \ | ||
| -DBOOST_INCLUDE_LIBRARIES=$SELF .. | ||
| cmake --build . | ||
| ctest --output-on-failure -R boost_$SELF | ||
|
|
||
| cd .. | ||
|
|
||
| if [ "$CMAKE_SHARED_LIBS" = 1 ]; then | ||
|
|
||
| mkdir __build_shared | ||
| cd __build_shared | ||
| cmake -DBOOST_ENABLE_CMAKE=1 -DBoost_VERBOSE=1 ${CMAKE_OPTIONS} \ | ||
| -DBOOST_INCLUDE_LIBRARIES=$SELF -DBUILD_SHARED_LIBS=ON .. | ||
| cmake --build . | ||
| ctest --output-on-failure -R boost_$SELF | ||
|
|
||
| fi | ||
|
|
||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 1690
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 267
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 311
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 78
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 290
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 89
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 305
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 176
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 3403
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 717
🏁 Script executed:
Repository: cppalliance/capy
Length of output: 2502
Replace Unix commands with native Windows equivalents in batch script.
Lines 22–23 use
cpandrm, which are not standard Windows commands and require external tools (Git for Windows, etc.). The repository's own batch file (doc/build_antora.bat) demonstrates the correct pattern by using only native Windows commands. Usexcopyandrmdirfor consistency and robustness.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents