code-coverage.yml update#158
Conversation
📝 WalkthroughWalkthroughModifies the GitHub Actions code-coverage workflow to add workflow_dispatch and concurrency, extend the build matrix (cxxstd), shift branch creation to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/code-coverage.yml:
- Around line 122-125: The workflow can have concurrent runs overwrite the
single amended commit; add a workflow-level concurrency block (e.g., after the
existing env: section) to serialize code-coverage runs by specifying a stable
group name like "code-coverage-pages" and set cancel-in-progress: false so runs
are queued rather than cancelling one another; update the workflow top-level
(not just the job) to include the concurrency stanza to prevent the git commit
--amend + git push -f step from clobbering other branch uploads.
- Around line 116-117: The two shell commands use inconsistent quoting for the
variable ${GITHUB_REF_NAME}; update the cp command so the destination is quoted
like the rm -rf command to avoid word-splitting or empty-variable issues.
Specifically change the cp -rp invocation to use
"gh_pages_dir/${GITHUB_REF_NAME}/" as the target (matching the rm -rf usage),
ensuring both rm -rf and cp reference the same quoted path
(gh_pages_dir/${GITHUB_REF_NAME}/) to prevent accidental copies into
gh_pages_dir// or word-splitting when GITHUB_REF_NAME is empty or contains
spaces.
- Line 118: The generated index HTML uses unquoted attribute values in the echo
command which produces lines like href=develop/index.html; update the echo
content in the workflow step that writes to gh_pages_dir/index.html so the
anchor tags use quoted hrefs (e.g., change href=develop/index.html and
href=master/index.html to href="develop/index.html" and
href="master/index.html") to produce valid HTML.
|
An automated preview of the documentation is available at https://158.corosio.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-02-20 22:31:57 UTC |
|
GCOVR code coverage report https://158.corosio.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-02-20 22:34:05 UTC |
sdarwin
force-pushed
the
feature/codecoverage
branch
from
d4c0127 to
9b40c76
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/code-coverage.yml (1)
77-80: Nit: quote$GITHUB_REF_NAMEon line 80 for consistency.The rest of the workflow carefully quotes this variable (lines 120-121). While branch names won't have spaces in practice, consistent quoting is good shell hygiene.
Proposed fix
- git checkout $GITHUB_REF_NAME + git checkout "$GITHUB_REF_NAME"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/code-coverage.yml around lines 77 - 80, Quote the GITHUB_REF_NAME variable in the git checkout command for consistency and safer shell handling: update the git checkout $GITHUB_REF_NAME invocation (the line that currently runs git checkout with GITHUB_REF_NAME) to use a quoted variable form so the command becomes git checkout "$GITHUB_REF_NAME" (preserving existing behavior while matching how other occurrences are quoted).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/code-coverage.yml:
- Around line 77-80: Quote the GITHUB_REF_NAME variable in the git checkout
command for consistency and safer shell handling: update the git checkout
$GITHUB_REF_NAME invocation (the line that currently runs git checkout with
GITHUB_REF_NAME) to use a quoted variable form so the command becomes git
checkout "$GITHUB_REF_NAME" (preserving existing behavior while matching how
other occurrences are quoted).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
- Coverage 82.26% 81.99% -0.28%
===========================================
Files 70 70
Lines 5876 5876
===========================================
- Hits 4834 4818 -16
- Misses 1042 1058 +16 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
3 participants
Latest version of the file from https://github.com/boostorg/boost-ci/blob/master/.github/workflows/code-coverage.yml
Summary by CodeRabbit