Change Dialog theme so that the dialog is scrollable if it overflows the viewport #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the viewport
If the Dialog component is `position: fixed` but is taller than the viewport, this means that the bottom of the Dialog (which is below the bottom of the viewport) cannot be reached other than by expanding the window, as the Dialog remains fixed in space relative to the viewport.
Changing the position setting to `relative` instead allows the Dialog to be scrolled, without the body moving.
A workaround while this PR is being considered it to set the following theme option:
```
<ThemeProvider
value={{
dialog: {
styles: {
base: {
backdrop: {
position: 'relative',
},
},
},
},
}}
>
```
The Dialog component is currently using floating-ui to handle blanking out the background of the screen, etc, and sets the `lockScroll` property. `lockScroll` does a number of different things, including hiding the scrollbar on the page and setting `overflow: hidden` on `<body>`.
|
@marlier is attempting to deploy a commit to the ct-tailwind-team Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Mar 12, 2024
oleksandr-andrushchenko
suggested changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Dialog component is
position: fixedbut is taller than the viewport, this means that the bottom of the Dialog (which is below the bottom of the viewport) cannot be reached other than by expanding the window, as the Dialog remains fixed in space relative to the viewport. A simple test case for this is to create a Dialog whose DialogBody has content<div className="block h-[4000px]">test</div>or some other similar thing.Changing the position setting to
relativeinstead allows the Dialog to be scrolled (independent of the page body.A workaround while this PR is being considered it to set the following theme option: