support alibaba oss #10068
Open
support alibaba oss #10068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Author
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alibaba cloud object storage is compatible with AWS S3, but requires different config.
In this change, rather than add additional option for alibaba oss, I reuse AWS S3 option, but when user specify the alibaba domain, then use the config for alibaba cloud.
Motivation and context
To support popular alibaba cloud.
How has this been tested?
I create the test environment, and tested with alibaba cloud oss key and secret
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.