Skip to content

[-] apply source config updates to existing gatherers #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0xgouda wants to merge 5 commits into from
Closed

[-] apply source config updates to existing gatherers #1090

0xgouda wants to merge 5 commits into from

Conversation

@0xgouda
Copy link
Collaborator

@0xgouda 0xgouda commented Dec 22, 2025 •
edited
Loading

  • Detect metrics that their interval or conn str got changed and stop them, on the next reaper iteration they new gatherers with the latest configs will be automatically started

Closes #1084, Closes #1085, Closes #1091

@coveralls
Copy link

coveralls commented Dec 22, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20438038458

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 73.635%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/reaper/database.go 0 4 0.0%
internal/reaper/reaper.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
internal/reaper/database.go 1 76.14%
Totals Coverage Status
Change from base Build 20326776768: -0.2%
Covered Lines: 3804
Relevant Lines: 5166
💛 - Coveralls

@0xgouda 0xgouda changed the title [-] apply updates to metric intervals on gatherers [-] apply source config updates to existing gatherers Dec 22, 2025
@0xgouda 0xgouda requested a review from pashagolub December 22, 2025 14:41
@0xgouda 0xgouda marked this pull request as draft December 23, 2025 10:37
@0xgouda
Copy link
Collaborator Author

0xgouda commented Jan 2, 2026

Taken by #1106

@0xgouda 0xgouda closed this Jan 2, 2026
@0xgouda 0xgouda deleted the handle-metric-interval-update branch January 2, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pashagolub pashagolub Awaiting requested review from pashagolub

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@0xgouda @coveralls