Skip to content

Comments

fix(shared): validate experience date range order#5533

Merged
idoshamun merged 2 commits intomainfrom
eng-759-feedback-bug-report-future-start-date-allowed-in-education
Feb 20, 2026
Merged

fix(shared): validate experience date range order#5533
idoshamun merged 2 commits intomainfrom
eng-759-feedback-bug-report-future-start-date-allowed-in-education

Conversation

@idoshamun
Copy link
Member

@idoshamun idoshamun commented Feb 20, 2026

Summary

  • add client-side Zod validation to prevent invalid experience date ranges where startedAt is after endedAt
  • keep validation scoped to endedAt so the existing field-level error rendering shows feedback in the right place
  • add focused hook tests covering invalid and valid date ordering paths

Key Decisions

  • kept backend validation unchanged and mirrored the same rule in the frontend for immediate UX feedback
  • used a user-facing message aligned with allowed behavior: end date can be equal to start date (on or after)
  • reused shared test setup in the new test cases to keep the spec concise and maintainable

Closes ENG-759


Created by Huginn 🐦‍⬛

Preview domain

https://eng-759-feedback-bug-report-futu.preview.app.daily.dev

@vercel
Copy link

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Feb 20, 2026 4:43pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Feb 20, 2026 4:43pm

Request Review

@idoshamun idoshamun merged commit 9a1a6f1 into main Feb 20, 2026
11 checks passed
@idoshamun idoshamun deleted the eng-759-feedback-bug-report-future-start-date-allowed-in-education branch February 20, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant