feat(shared): implement shared element transition for post modal using framer-motion#5535
Open
tsahimatsliah wants to merge 2 commits intomainfrom
Open
feat(shared): implement shared element transition for post modal using framer-motion#5535tsahimatsliah wants to merge 2 commits intomainfrom
tsahimatsliah wants to merge 2 commits intomainfrom
Conversation
…g framer-motion - Add framer-motion dependency - Map layoutIds between feed cards and modal for seamless expansion - Remove manual modal overlays and old pull-to-close logic - Ensure smooth layout morphing on open/close Co-authored-by: Cursor <cursoragent@cursor.com>
tsahimatsliah
requested review from
AmarTrebinjac,
capJavert,
omBratteng and
rebelchris
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
framer-motiondependency to@dailydotdev/sharedpackage.layoutIds between feed cards (ListCard) and the opened modal (BasePostModalandPostContent) for seamless expansion and collapse.Test plan
framer-motiondoes not introduce unintended side effects in other layouts.Made with Cursor
Preview domain
https://fix-shared-element-transition.preview.app.daily.dev