fixed #14347 - fixed Clang warnings in C++20 build #8021
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
firewave
force-pushed
the
cxx20
branch
2 times, most recently
from
774d19d to
7a010b5
Compare
firewave
changed the title
-Wdeprecated-this-capture Clang C++20 warning
firewave
changed the title
|
The CI jobs will not trigger the warnings which have been fixed by this. A Clang build is implicitly performed by the clang-tidy job. We could switch that job to a higher standard (C++23 even) and adjust the configuration accordingly. This would also allow us to introduce some more conditional modernizations. |
firewave
force-pushed
the
cxx20
branch
3 times, most recently
from
2260091 to
c107e0e
Compare
not true - macOS obviously uses Clang... |
|
The C++20 builds fails for macOS: |
firewave
force-pushed
the
cxx20
branch
2 times, most recently
from
9fb3f5d to
a7306be
Compare
gui/resultstree.cpp
Outdated
| auto *action = new QAction(tr("No tag"), tagMenu); | ||
| tagMenu->addAction(action); | ||
| connect(action, &QAction::triggered, [=]() { | ||
| connect(action, &QAction::triggered, [EXPLICIT_THIS]() { |
There was a problem hiding this comment.
can't this be rewritten so it's compatible both with c++20 and c++14 ? [this] ?
There was a problem hiding this comment.
That works. Thanks.
gui/resultstree.cpp
Outdated
| auto *action = new QAction(tagstr, tagMenu); | ||
| tagMenu->addAction(action); | ||
| connect(action, &QAction::triggered, [=]() { | ||
| connect(action, &QAction::triggered, [EXPLICIT_THIS]() { |
There was a problem hiding this comment.
That works. Thanks.
example:
```
/home/user/CLionProjects/cppcheck/lib/pathmatch.cpp:37:37: warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture]
37 | return match(pattern, path, mBasepath, mode, mSyntax);
| ^
/home/user/CLionProjects/cppcheck/lib/pathmatch.cpp:36:63: note: add an explicit capture of 'this' to capture '*this' by reference
36 | return std::any_of(mPatterns.cbegin(), mPatterns.cend(), [=] (const std::string &pattern) {
| ^
| , this
```
Co-authored-by: Daniel Marjamäki <daniel.marjamaki@gmail.com>
|
2 participants
No description provided.