You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
r.raise_for_status() is really bad at handling issues within a wrapper. I would rather have error handling similar to the one implemented in Add error handling, fix broken unit tests #260 or not at all.
rate-limiting should be handled outside of each method call. This is a bigger project so we should not worry about it here, but please do not use time.sleep() within any method.
r.raise_for_status() is really bad at handling issues within a wrapper. I would rather have error handling similar to the one implemented in #260 or not at all.
I only used it for debugging, and I've removed it. (I used the authenticated_client as a template)
rate-limiting should be handled outside of each method call. This is a bigger project so we should not worry about it here, but please do not use time.sleep() within any method.
But since this will perform recursion it will always be rate limited. I have commented it out but I think we need a way to handle it properly.
PS if #260 gets merged I could adapt the code to use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the pagination of trades, as per the api docs (https://docs.gdax.com/#get-trades).