Missed num of skip #5
Conversation
And have extra , in cid
| skip = ns, | ||
| fail = nf, | ||
| error = ne, | ||
| cid = 'c%s' % (cid+1), |
There was a problem hiding this comment.
@howareyou The trailing comma is syntactically correct in Python. It is useful for adding lines later without raising a syntax error when someone forgets that a comma was actually needed in the preceding.
Other than your personal preference, is there some reason for removing it? If not, then it complicates the git history without adding value. I suggest removing it from the commit.
There was a problem hiding this comment.
As far as the rest of the commit, it looks fine to me.
As to a test case, I am slammed with work and am working a lot of overtime. I am not sure I can carve out much time right now. I am happy to review whatever is submitted, but I can't make promises as to actually generating any code myself.
|
@dash0002 I am a newbie at Python:), and add trailing comma back |
|
No worries @howareyou. Just glad to have people involved in the fork. I won't be merging until the test case is written, but there's no rush and it's a good experience also. |
3 participants
And have extra , in cid