-
Notifications
You must be signed in to change notification settings - Fork 34
[Feature] Support for Unified Host #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tanmay-db
wants to merge
6
commits into
main
Choose a base branch
from
spog-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
databricks-sdk-java/src/main/java/com/databricks/sdk/AccountClient.java
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
13 changes: 13 additions & 0 deletions
13
databricks-sdk-java/src/main/java/com/databricks/sdk/core/ClientType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package com.databricks.sdk.core; | ||
|
|
||
| import com.databricks.sdk.support.InternalApi; | ||
|
|
||
| /** Represents the type of Databricks client being used for API operations. */ | ||
| @InternalApi | ||
| public enum ClientType { | ||
| /** Workspace client (traditional or unified host with workspaceId). */ | ||
| WORKSPACE, | ||
|
|
||
| /** Account client (traditional or unified host without workspaceId). */ | ||
| ACCOUNT | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
databricks-sdk-java/src/main/java/com/databricks/sdk/core/HostType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package com.databricks.sdk.core; | ||
|
|
||
| import com.databricks.sdk.support.InternalApi; | ||
|
|
||
| /** Represents the type of Databricks host being used. */ | ||
| @InternalApi | ||
| public enum HostType { | ||
| /** Traditional workspace host. */ | ||
| WORKSPACE, | ||
|
|
||
| /** Traditional accounts host. */ | ||
| ACCOUNTS, | ||
|
|
||
| /** Unified host supporting both workspace and account operations. */ | ||
| UNIFIED | ||
| } |
36 changes: 36 additions & 0 deletions
36
databricks-sdk-java/src/main/java/com/databricks/sdk/core/UnifiedHostHeaderFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package com.databricks.sdk.core; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * HeaderFactory wrapper that adds X-Databricks-Org-Id header for unified host workspace operations. | ||
| */ | ||
| class UnifiedHostHeaderFactory implements HeaderFactory { | ||
| private final HeaderFactory delegate; | ||
| private final String workspaceId; | ||
|
|
||
| /** | ||
| * Creates a new unified host header factory. | ||
| * | ||
| * @param delegate The underlying header factory (e.g., OAuth, PAT) | ||
| * @param workspaceId The workspace ID to inject in the X-Databricks-Org-Id header | ||
| */ | ||
| public UnifiedHostHeaderFactory(HeaderFactory delegate, String workspaceId) { | ||
| if (delegate == null) { | ||
| throw new IllegalArgumentException("delegate cannot be null"); | ||
| } | ||
| if (workspaceId == null || workspaceId.isEmpty()) { | ||
| throw new IllegalArgumentException("workspaceId cannot be null or empty"); | ||
| } | ||
| this.delegate = delegate; | ||
| this.workspaceId = workspaceId; | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, String> headers() { | ||
| Map<String, String> headers = new HashMap<>(delegate.headers()); | ||
| headers.put("X-Databricks-Org-Id", workspaceId); | ||
| return headers; | ||
| } | ||
| } |
75 changes: 75 additions & 0 deletions
75
databricks-sdk-java/src/test/java/com/databricks/sdk/AccountClientTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| package com.databricks.sdk; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| import com.databricks.sdk.core.ClientType; | ||
| import com.databricks.sdk.core.DatabricksConfig; | ||
| import com.databricks.sdk.core.HostType; | ||
| import com.databricks.sdk.service.provisioning.Workspace; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class AccountClientTest { | ||
|
|
||
| @Test | ||
| public void testGetWorkspaceClientForTraditionalAccount() { | ||
| DatabricksConfig accountConfig = | ||
| new DatabricksConfig() | ||
| .setHost("https://accounts.cloud.databricks.com") | ||
| .setAccountId("test-account") | ||
| .setToken("test-token"); | ||
|
|
||
| AccountClient accountClient = new AccountClient(accountConfig); | ||
|
|
||
| Workspace workspace = new Workspace(); | ||
| workspace.setWorkspaceId(123L); | ||
| workspace.setDeploymentName("test-workspace"); | ||
|
|
||
| WorkspaceClient workspaceClient = accountClient.getWorkspaceClient(workspace); | ||
|
|
||
| // Should have a different host | ||
| assertNotEquals(accountConfig.getHost(), workspaceClient.config().getHost()); | ||
| assertTrue(workspaceClient.config().getHost().contains("test-workspace")); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetWorkspaceClientForUnifiedHost() { | ||
| String unifiedHost = "https://unified.databricks.com"; | ||
| DatabricksConfig accountConfig = | ||
| new DatabricksConfig() | ||
| .setHost(unifiedHost) | ||
| .setExperimentalIsUnifiedHost(true) | ||
| .setAccountId("test-account") | ||
| .setToken("test-token"); | ||
|
|
||
| AccountClient accountClient = new AccountClient(accountConfig); | ||
|
|
||
| Workspace workspace = new Workspace(); | ||
| workspace.setWorkspaceId(123456L); | ||
| workspace.setDeploymentName("test-workspace"); | ||
|
|
||
| WorkspaceClient workspaceClient = accountClient.getWorkspaceClient(workspace); | ||
|
|
||
| // Should have the same host | ||
| assertEquals(unifiedHost, workspaceClient.config().getHost()); | ||
|
|
||
| // Should have workspace ID set | ||
| assertEquals("123456", workspaceClient.config().getWorkspaceId()); | ||
|
|
||
| // Should be workspace client type (on unified host) | ||
| assertEquals(ClientType.WORKSPACE, workspaceClient.config().getClientType()); | ||
|
|
||
| // Host type should still be unified | ||
| assertEquals(HostType.UNIFIED, workspaceClient.config().getHostType()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetWorkspaceClientForUnifiedHostType() { | ||
| // Verify unified host type is correctly detected | ||
| DatabricksConfig config = | ||
| new DatabricksConfig() | ||
| .setHost("https://unified.databricks.com") | ||
| .setExperimentalIsUnifiedHost(true); | ||
|
|
||
| assertEquals(HostType.UNIFIED, config.getHostType()); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the workspace id also added to the headers for this call?
If not, how does the backend know which ws to use?
A bit unrelated but: what happens if we send the accountId?