ParameterStatus on SET statements#293
Open
TwistingTwists wants to merge 10 commits intodatafusion-contrib:masterfrom
Open
ParameterStatus on SET statements#293TwistingTwists wants to merge 10 commits intodatafusion-contrib:masterfrom
TwistingTwists wants to merge 10 commits intodatafusion-contrib:masterfrom
Conversation
DateStyle and IntervalStyle must match the casing sent during startup.
Merge unit tests for parameter_status_key_for_set into single table-driven test. Add handler-level tests that call do_query() and assert ParameterStatus messages appear in MockClient's sent_messages, closing the gap where the actual feed() path was untested. Remove standalone timezone SingleAssignment case from parameter_status_key_for_set (SET TIME ZONE uses SetTimeZone).
Author
|
I fixed the cargo fmt issue. Can you trigger the CI please @sunng87 ? |
sunng87
reviewed
Feb 22, 2026
Member
sunng87
left a comment
sunng87
left a comment
There was a problem hiding this comment.
Thank you @TwistingTwists ! Please check my comments about moving the logic into our QueryHook completely.
| { | ||
| if result.is_ok() { | ||
| if let Some((name, value)) = | ||
| set_show::parameter_status_key_for_set(&statement, client) |
Member
There was a problem hiding this comment.
I haven't checked the order of returned packets for SET statements, I wonder if it's possible to add this logic to set_show's try_respond_set_statements. We can modify the definition of client in QueryHook if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix: #242