fix: Remove unit tests from pre-commit hooks#1363
Merged
dimitri-yatsenko merged 1 commit intomasterfrom Jan 30, 2026
Merged
Conversation
Pre-commit hooks should be fast. Running tests on every commit: - Slows down the development workflow - Fails legitimately when creating reproducers before fixes Tests are better suited for CI workflows where they run in parallel and don't block local commits. Fixes #1356 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
bug
dimitri-yatsenko
removed
the
bug
d-v-b
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unit tests from pre-commit hooks.
Rationale
Pre-commit hooks should be fast. Running tests on every commit:
Tests are better suited for CI workflows (GitHub Actions) where they:
Changes
unit-testshook from.pre-commit-config.yamlTests continue to run via GitHub Actions on push/PR.
Fixes #1356
🤖 Generated with Claude Code