Don't attempt to UTF-8 decode binary values #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat all binary values the same: render them as hex literals. The existing logic allows some binary values to be treated differently than others.
Contributor
Author
|
If anyone wants to recover the old behavior, I think we could make it an option. |
rolandwalker
added a commit
that referenced
this pull request
Jan 26, 2026
This reverts commit 15519e2.
rolandwalker
added a commit
that referenced
this pull request
Jan 26, 2026
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Treat all binary values the same: render them as hex literals. The existing logic allows some binary values to be treated differently than others.
See dbcli/mycli#1010 for an example of this kind of problem.
Checklist
CHANGELOG.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install), and ranblackon my code.