Open
Conversation
|
Findings
Missing tests / edge cases
If you want, I can sketch a minimal pytest for this. |
3 tasks
* open documentation index in web browser * emit output using prompt_toolkit methods such that the prompt is restored including pending input * include the docs URL in the output in case the browser did not open * include alternate F1 key sequence that prompt_toolkit doesn't handle * update TIPS and key_bindings.rst
f561b53 to
c59f091
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
prompt_toolkitmethods such that the prompt is restored including pending inputprompt_toolkitdoesn't handleTIPSandkey_bindings.rstChecklist
changelog.mdfile.AUTHORSfile (or it's already there).