Open
Conversation
|
Findings
Missing Tests / Edge Cases
No security issues spotted in the changes. |
2b48c9d to
986be5f
Compare
* create a new postamble property in SQLResult, representing nontabular footer output * refer to SQLResult properties directly more often, eliding temporary variables * convert some old-style SQLResult() constructors in the tests to named parameters Motivation: the "status" _property_ to a SQLResult is not included in the paged output. This was noticeable in the output of the "status" _command_, which includes a non-tabular footer which is more naturally part of the paged output. This suggests a few other changes, such as recasting SQLResult.title as SQLResult.preamble.
986be5f to
ee1dd8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
postambleproperty in SQLResult representing nontabular footer output.SQLResultproperties directly more often, eliding temporary variables.SQLResult()constructors in the tests to named parameters.Motivation: the
statusproperty to aSQLResultis not included in the paged output. This was noticeable in the output of thestatuscommand, which includes a non-tabular footer which is more naturally part of the paged output.This suggests a few other changes, such as recasting
SQLResult.titleasSQLResult.preamble. The trailing line in #1628 would more naturally be apostamblethan astatus.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).