-
Notifications
You must be signed in to change notification settings - Fork 5
feat(vm): add target migration #1874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hardcoretime
wants to merge
20
commits into
main
Choose a base branch
from
feat/vm/add-target-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
065512f to
cca7297
Compare
z9r5
previously approved these changes
Jan 20, 2026
yaroslavborbat
requested changes
Jan 20, 2026
images/virtualization-artifact/pkg/controller/vmop/migration/internal/service/migration.go
Show resolved
Hide resolved
yaroslavborbat
requested changes
Jan 20, 2026
cca7297 to
d804996
Compare
yaroslavborbat
requested changes
Jan 21, 2026
images/virtualization-artifact/pkg/controller/vmop/migration/internal/service/migration.go
Outdated
Show resolved
Hide resolved
yaroslavborbat
previously approved these changes
Jan 21, 2026
6fe45ee to
1f02fd0
Compare
denmaloyreb
previously approved these changes
Jan 26, 2026
21f1703 to
fd9349f
Compare
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
- add default Alpine-BIOS virtual disk - set the value to '20%' as the default in NewMinimalVM Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
- replace nodeSelector with targetNodeName in d8 v migrate - target migration is EE feature Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
5a3758a to
6eabe39
Compare
denmaloyreb
reviewed
Jan 26, 2026
| description: |- | ||
| Селектор меток узла для планирования виртуальной машины на узел. Должен соответствовать меткам целевого узла. | ||
| [По аналогии](https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes/) с параметром подов `spec.nodeSelector` в Kubernetes. | ||
| Примечание: поле `nodeSelector` недоступно в версии Community Edition. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| Примечание: поле `nodeSelector` недоступно в версии Community Edition. | |
| > Поле `nodeSelector` недоступно в версии Community Edition. |
| description: |- | ||
| Node selector for scheduling the VM onto a node. Must match the target node's labels. | ||
| [Same](https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes/) as the Pod `spec.nodeSelector` field in Kubernetes. | ||
| Note: the `nodeSelector` field is not available in the Community Edition version. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| Note: the `nodeSelector` field is not available in the Community Edition version. | |
| > The `nodeSelector` field is not available in the Community Edition version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A virtual machine can now be migrated to a particular node using the NodeSelector option in the virtual machine operation.
Why do we need it, and what problem does it solve?
This is required to enhance the user experience with virtual machine migration.
What is the expected result?
A virtual machine can be migrated to a particular node using defined labels.
Checklist
Changelog entries