fix(vm): increase memory limits during migration with hotplugged disks #1947
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change kubevirt behaviour for target Pod: add 60Mi more memory to the target Pod resource requirements depending on coreFraction value: - Increase requests and limits if cpu cores are guaranteed (coreFraction = 100%) - Increase limits only if cpu cores are not guaranteed (coreFraction < 100%). Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
diafour
requested review from
yaroslavborbat
and removed request for
Isteb4k and
fl64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change kubevirt behaviour for target Pod: add 60Mi more memory to the target Pod resource requirements depending on coreFraction value:
See deckhouse/3p-kubevirt#66
Why do we need it, and what problem does it solve?
This additional memory should prevent OOMKills for the target Pod during VM migration with hotplugged disks.
What is the expected result?
VM with 16 hotplugged disks migrates with no OOMKills.
Checklist
Changelog entries