Skip to content

Conversation

@sunliang98
Copy link
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Add override to Pot_ML_EXX::cal_v_eff to avoid compilation warning.
  • Provide a clearer, friendlier error when ML KEDF is used without ENABLE_MLALGO.
  • Add validation for out_elf and spin=4 combo.

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@sunliang98 sunliang98 requested a review from mohanchen January 26, 2026 08:10
@sunliang98 sunliang98 changed the title Fix: enhance several warning message Fix: enhance several warning messages Jan 26, 2026
@mohanchen mohanchen added Refactor Refactor ABACUS codes Input&Output Suitable for coders without knowing too many DFT details labels Jan 26, 2026
@mohanchen mohanchen merged commit e9dc0b7 into deepmodeling:develop Jan 26, 2026
14 checks passed
@sunliang98 sunliang98 deleted the fix_warning branch January 26, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Input&Output Suitable for coders without knowing too many DFT details Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants