Fix Muon optimizer checkpoint resume with bf16 mode #7748
+133
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
load_state_dictoverride to castmomentum_bufferto match parameter dtype after loadingRoot Cause
When resuming training from a checkpoint with
bf16enabled:momentum_bufferis saved asfp32in the checkpointload_state_dict(),momentum_bufferremainsfp32bf16momentum.lerp_(grad, 1 - beta)crashes due to dtype mismatchFix
Added
load_state_dictoverride to all Muon optimizer classes that casts optimizer state buffers to match the parameter dtype after loading:Muonmomentum_bufferSingleDeviceMuonmomentum_bufferMuonWithAuxAdammomentum_buffer,exp_avg,exp_avg_sqSingleDeviceMuonWithAuxAdammomentum_buffer,exp_avg,exp_avg_sqTest Plan
TestMuonBF16CheckpointResumetest class that:Fixes: #7746
🤖 Generated with Claude Code