Extend CT0002 to detect enum cast expressions with numeric literals #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CT0002 enum assignment analyzer previously only flagged direct literal assignments to enum properties but missed cast expressions with numeric literals. This enhancement extends the analyzer to also detect problematic patterns like:
Changes Made
Enhanced Detection Logic: Modified both
AnalyzeEnumAssignmentandAnalyzeEnumAssignmentForPropertymethods to detect:Comprehensive Test Coverage: Added new test cases covering:
EnumPropertyAssignedCastShouldTrigger)EnumCastWithDataverseNamingPatternShouldTrigger)PropertyInitializerWithCastShouldTrigger)MemberAccessEnumAssignedCastShouldTrigger)EnumCastFromVariableShouldNotTrigger)The analyzer now properly encourages developers to use proper enum values instead of casting numeric literals, improving code maintainability and reducing magic numbers in Dataverse-related code.
Fixes #11.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.