Remove invalid @Override from JavadocComment visitor for 3.28.0 compatibility#84
Merged
eNeRGy164 merged 2 commits intodependabot/maven/com.github.javaparser-javaparser-symbol-solver-core-3.28.0from Feb 2, 2026
Conversation
Co-authored-by: eNeRGy164 <10671831+eNeRGy164@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update com.github.javaparser:javaparser-symbol-solver-core to 3.28.0
Remove invalid @Override from JavadocComment visitor for 3.28.0 compatibility
Feb 2, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase for compatibility with JavaParser 3.28.0, which refactored the comment hierarchy to support MarkdownComments (as noted in javaparser/javaparser#4885). The refactoring made the visit(JavadocComment) method no longer overrideable in GenericListVisitorAdapter, requiring removal of the @Override annotation.
Changes:
- Removed
@Overrideannotation fromvisit(JavadocComment, Analyzer)method in AnalysisVisitor.java
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3feb5ed
into
dependabot/maven/com.github.javaparser-javaparser-symbol-solver-core-3.28.0
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaParser 3.28.0 refactored the comment hierarchy (PR javaparser/javaparser#4885) to support MarkdownComments. The
visit(JavadocComment)method is no longer overrideable inGenericListVisitorAdapter.Changes
@Overrideannotation fromvisit(JavadocComment, Analyzer)inAnalysisVisitor.javaThe method implementation remains unchanged—only the annotation is removed. Existing tests in
AnalysisVisitorTest.java(lines 296-350, 410-426) verify Javadoc parsing continues to work correctly.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.