Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 2, 2026

JavaParser 3.28.0 changed JavadocComment from a concrete class to an abstract class, introducing TraditionalJavadocComment as the concrete implementation.

Changes

  • AnalysisVisitor: Changed visit(JavadocComment n, Analyzer arg) to visit(TraditionalJavadocComment n, Analyzer arg) and added @Override annotation to properly override the visitor method from GenericListVisitorAdapter
  • CommentHelperMethodsTest: Updated test instantiation from new JavadocComment(...) to new TraditionalJavadocComment(...)
  • CommentHelperMethods: No changes required—methods continue accepting JavadocComment (abstract parent) for compatibility with all subclasses
// Before (3.27.1)
public List<Description> visit(JavadocComment n, Analyzer arg) {
  // ...
}

// After (3.28.0)
@Override
public List<Description> visit(TraditionalJavadocComment n, Analyzer arg) {
  // ...
}

The visitor pattern in 3.28.0 exposes visit(TraditionalJavadocComment, A) instead of visit(JavadocComment, A), requiring the method signature change to properly override the parent class method.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: eNeRGy164 <10671831+eNeRGy164@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 2, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/dendrodocs/java-tool/actions/runs
    • Triggering command: /usr/bin/curl curl -s -H Accept: application/vnd.github&#43;json REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Bump com.github.javaparser:javaparser-symbol-solver-core to 3.28.0 Fix JavaParser 3.28.0 API compatibility: Use TraditionalJavadocComment Feb 2, 2026
Copilot AI requested a review from eNeRGy164 February 2, 2026 12:28
@eNeRGy164 eNeRGy164 marked this pull request as ready for review February 2, 2026 12:28
Copilot AI review requested due to automatic review settings February 2, 2026 12:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the codebase to be compatible with JavaParser 3.28.0, which changed JavadocComment from a concrete class to an abstract class with TraditionalJavadocComment as the concrete implementation.

Changes:

  • Updated the visitor method signature in AnalysisVisitor to accept TraditionalJavadocComment and added @Override annotation
  • Updated test code to instantiate TraditionalJavadocComment instead of JavadocComment

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/main/java/dev/dendrodocs/tool/AnalysisVisitor.java Changed visitor method from JavadocComment to TraditionalJavadocComment parameter and added @Override annotation to properly override parent visitor method
src/test/java/dev/dendrodocs/tool/helpermethods/CommentHelperMethodsTest.java Updated test instantiation from new JavadocComment(...) to new TraditionalJavadocComment(...)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eNeRGy164 eNeRGy164 merged commit 5c18eda into dependabot/maven/com.github.javaparser-javaparser-symbol-solver-core-3.28.0 Feb 2, 2026
7 checks passed
@eNeRGy164 eNeRGy164 deleted the copilot/sub-pr-80 branch February 2, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants