-
Notifications
You must be signed in to change notification settings - Fork 67
Update devfile with ephemeral graphroot directory #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: dkwon17 <dakwon@redhat.com>
Signed-off-by: dkwon17 <dakwon@redhat.com>
1432bbe to
dc825f8
Compare
|
I've also added a |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1576 +/- ##
==========================================
+ Coverage 34.60% 36.01% +1.41%
==========================================
Files 160 166 +6
Lines 13387 14283 +896
==========================================
+ Hits 4632 5144 +512
- Misses 8442 8798 +356
- Partials 313 341 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| export DWO_IMG=${DWO_IMG_REPO}/devworkspace-controller:${DWO_IMG_TAG} | ||
| export DOCKER=podman | ||
| make docker-build-amd64 | ||
| make docker-push-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine if the target cluster is always amd64, but it can be surprising if someone later targets an arm64 cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now, it's okay to only target amd64 for development. OOTB, I'm not able to build arm64 images in the workspace:
[2/2] STEP 1/11: FROM --platform=linux/arm64 registry.access.redhat.com/ubi9-minimal:9.6-1749489516
[2/2] STEP 2/11: RUN microdnf -y update && microdnf clean all && rm -rf /var/cache/yum && echo "Installed Packages" && rpm -qa | sort -V && echo "End Of Installed Packages"
process failed to start with error: fork/exec /bin/sh: exec format error
process exited with error: exec: not started
subprocess exited with status 1
Error: building at STEP "RUN microdnf -y update && microdnf clean all && rm -rf /var/cache/yum && echo "Installed Packages" && rpm -qa | sort -V && echo "End Of Installed Packages"": exit status 1
Let's add arm64 build functionality in a seperate PR
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
After review with @btjd, there was an issue with quay.io/devfile/devworkspace-devtools:latest (quay.io/devfile/devworkspace-devtools:sha-0607887), where podman was not available in our cloud development environment. However, I just tried it again, and podman is available: Not sure what happened? Perhaps it's a cluster issue, and not an issue with this PR |
49db739 to
dc825f8
Compare

What does this PR do?
Mounts an ephemeral volume to the graphroot directory. Without this change,
out of spaceerrors would occur for image builds.This PR also updates the devfile tasks for building and pushing DWO images.
What issues does this PR fix or reference?
Is it tested? How?
To test, run the
build-and-push-controllerandmake-olm-bundle-index-catalogsourcedevfile tasks. They should both run successfully.PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che