Sort automount configmaps and secrets to ensure deterministic ordering

[dkwon17]

What does this PR do?

Sorts automount configmaps and secrets so that they are ordered the same way for each devworkspace reconciliation. Sorting is done, since otherwise, there is no guarantee on the configmap/secret ordering returned by api.Client.List. This can cause the ordering to differ between DevWorkspace reconciliations, causing the problem described in #1572 (comment).

A similar change was made in the past with git credentials: e17e799.

In this PR, we apply the same idea to the automount secrets and configmaps.

What issues does this PR fix or reference?

#1572 (comment)

Is it tested? How?

It can be tested by running:

git clone https://github.com/dkwon17/test-automount-ordering
cd test-automount-ordering
./create-secrets.sh
./test-ordering.sh
./cleanup.sh

The output should include:

✅ CONFIRMED: Volumes are sorted alphabetically (fix is working!)

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[dkwon17]

I plan to create e2e tests for this PR, in a new commit

[dkwon17]

/retest

[rohanKanojia]

I tested with the abovementioned steps and PR seems to be working as expected ✔️

[dkwon17]

/retest

[openshift-ci]

@dkwon17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v14-che-happy-path	3913464	link	true	/test v14-che-happy-path

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akurinnoy, dkwon17, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dkwon17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment