Skip to content

new icon: emailjs (original, original-wordmark, plain-wordmark)#2640

Open
KekMuzaffer wants to merge 10 commits intodevicons:developfrom
KekMuzaffer:develop
Open

new icon: emailjs (original, original-wordmark, plain-wordmark)#2640
KekMuzaffer wants to merge 10 commits intodevicons:developfrom
KekMuzaffer:develop

Conversation

@KekMuzaffer
Copy link

@KekMuzaffer KekMuzaffer commented Feb 3, 2026

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #845

Link to prove your SVG is correct and up-to-date.

https://www.emailjs.com/

@KekMuzaffer
Copy link
Author

PR is ready for review; please approve workflows and run checks.

@weh weh added the feature:icon PR when a new icon is ready to be added to the collection label Feb 5, 2026
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KekMuzaffer, thank you for your contribution.

i have two points to update.

  1. Replace the plain version with a plain-wordmark version
    see my other comment, but basically original can be used as an alias for plain in this case.

  2. add a empty line to each *.svg file
    some Editors need the .svg files to have a empty line at the end.

Image

Also a general tip to work with github repositories. You should keep the main branches (in our case master and develop) unchanged in your repository. If you want to add something, create a feature branch named like "new-icon-foo" or whatever style you like. This makes it easier for you, to update your own repository forks master and develop branch, if you plan to add more icons later.

@KekMuzaffer
Copy link
Author

KekMuzaffer commented Feb 10, 2026

Hi @weh, I’ve applied all requested changes (plain-wordmark, aliases, and empty lines in SVGs). Ready for another review.

I have a question about the trailing blank line in the SVG files.
Locally, each emailjs-*.svg now has an empty line after </svg>, but in GitHub’s diff view I don’t see that blank line rendered. I’ve read that GitHub often doesn’t visually show the final newline, so I want to confirm: do the files look correct on your side, or is there still something I should change regarding the trailing newline?

@KekMuzaffer KekMuzaffer requested a review from weh February 17, 2026 13:46
@weh weh added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger bot:check Trigger check-bot. Remove and re-add the label to re-trigger labels Feb 25, 2026
@weh weh requested review from a team, Snailedlt, canaleal and lunatic-fox and removed request for a team February 25, 2026 14:46
@weh weh changed the title new icon: emailjs (original, original-wordmark, plain) new icon: emailjs (original, original-wordmark, plain-wordmark) Feb 25, 2026
@weh weh added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:check Trigger check-bot. Remove and re-add the label to re-trigger bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants