-
Notifications
You must be signed in to change notification settings - Fork 571
add pro deployment #2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pro deployment #2012
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe deployment configuration for the "projects-refresh-service" app was split from the existing workflow, which now targets the "pro" app. A new workflow was added for "projects-refresh-service" deployment, while the original workflow was updated to deploy the "pro" app with the appropriate environment variables and configuration. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Restructures deployment workflows by splitting pro backend and projects-refresh-service into separate pipelines for better deployment management.
- Modifies
.github/workflows/pro-deploy.ymlto usefly-pro.tomlconfiguration andFLYIO_PRO_TOKENfor pro backend deployment - Adds new
.github/workflows/pro-projects-service-deploy.ymlfor dedicated projects-refresh-service deployment pipeline - Both workflows include concurrency controls to prevent simultaneous deployments to their respective services
2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
.github/workflows/pro-deploy.yml
Outdated
| name: Deploy projects-refresh-service app | ||
| name: Deploy pro app | ||
| runs-on: ubuntu-latest | ||
| concurrency: projects-refresh # optional: ensure only one action runs at a time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Concurrency group 'projects-refresh' should be updated to 'pro-deploy' for clarity and to avoid conflicts
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: superfly/flyctl-actions/setup-flyctl@master | ||
| - run: flyctl deploy --remote-only --config fly-projects-refresh-service.toml --image-label latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: using 'latest' tag for deployments can be risky as it may lead to unintended deployments - consider using a specific version tag or commit SHA
| - run: flyctl deploy --remote-only --config fly-projects-refresh-service.toml --image-label latest | |
| - run: flyctl deploy --remote-only --config fly-projects-refresh-service.toml --image-label ${{ github.sha }} |
|
✅ No security or compliance issues detected. Reviewed everything up to aa64251. Security Overview
Detected Code Changes
Reply to this PR with |
* add pro deployment * upd group
Summary by CodeRabbit