1.8.8 #239
Merged
1.8.8 #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 1, 2026
Contributor
📝 WalkthroughWalkthroughBumps release/version metadata (v1.8.7 → v1.8.8), adds terminal image-protocol detection (Kitty/Sixel) and image protocol return, converts several synchronous data fetches to asynchronous message-driven flows with spinners for sets/cards, centralizes yellow styling, and adds a CallTCGData HTTP helper plus related tests and deps. Changes
Sequence Diagram(s)sequenceDiagram
participant UI as Client / UI
participant T as Tea Runtime
participant Fetch as Fetcher (fetch*Cmd)
participant Conn as Connections.CallTCGData
participant API as TCG API
UI->>T: Init() returns spinner.Tick + fetch*Cmd
T->>Fetch: run fetch*Cmd(series/set id)
Fetch->>Conn: CallTCGData(url) (headers + timeout)
Conn->>API: HTTP GET
API-->>Conn: 200 + payload
Conn-->>Fetch: []byte payload
Fetch-->>T: cardDataMsg / setsDataMsg (rows/maps or error)
T->>UI: Update(msg) -> populate model, stop spinner, render table
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
digitalghost-dev
force-pushed
the
1.8.8
branch
from
b72cd63 to
ba386d3
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@go.mod`:
- Around line 15-16: The go.mod additions introduce two dependencies with
maintenance risk: github.com/schollz/closestmatch (v2.1.0+incompatible) and
github.com/dolmen-go/kittyimg (pseudo-version); update project documentation and
dependency management: add a short note in the repo README or DEPENDENCIES file
referencing these modules (github.com/schollz/closestmatch and
github.com/dolmen-go/kittyimg), set up monitoring (subscribe or add entries to
your vulnerability/monitoring sources such as GitHub Advisory Database and
pkg.go.dev/vuln), and consider replacing them with more actively maintained
alternatives or vendoring a copy if reproducibility is required—if you choose to
replace, search for equivalents and update imports/usages where functions from
closestmatch and kittyimg are referenced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Style
Documentation
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.