dont fallback on certain errors when using a models gateway#1798
Draft
krissetto wants to merge 1 commit intodocker:mainfrom
Draft
dont fallback on certain errors when using a models gateway#1798krissetto wants to merge 1 commit intodocker:mainfrom
krissetto wants to merge 1 commit intodocker:mainfrom
Conversation
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
dgageot
approved these changes
Feb 20, 2026
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Summary
✅ No issues found in the changed code.
I've reviewed all the added code in this PR and verified:
- Validation logic: Properly checks that status codes are in the 400-599 range with appropriate nil guards
- Integration: Correctly wires up the configuration from YAML through to the runtime
- Runtime logic: The no-fallback check is appropriately placed and only triggers when both a gateway is configured AND matching status codes are returned
- Test coverage: Three comprehensive tests cover the main scenarios (no-fallback trigger, normal fallback for other codes, no effect without gateway)
- Consistency: Follows existing patterns in the codebase for option handling and slice management
The implementation is clean and well-tested. Once you've completed your testing and removed the "do not merge" note, this should be good to go! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not properly tested, do not merge