Conversation
Member
dgageot
commented
Feb 21, 2026
| Module | From | To | Status |
|---|---|---|---|
| github.com/anthropics/anthropic-sdk-go | v1.24.0 | v1.26.0 | bumped |
| github.com/aws/aws-sdk-go-v2/config | v1.32.8 | v1.32.9 | bumped |
| github.com/aws/aws-sdk-go-v2/credentials | v1.19.8 | v1.19.9 | bumped (with config) |
| github.com/aymanbagabas/go-udiff | v0.3.1 | v0.4.0 | bumped |
| github.com/dop251/goja | v0.0.0-20260216154549-8b74ce4618c5 | v0.0.0-20260219130522-0ba9a5494a59 | |
| bumped | |||
| github.com/google/go-containerregistry | v0.20.7 | v0.21.0 | bumped |
| github.com/junegunn/fzf | v0.67.0 | v0.68.0 | bumped |
| github.com/modelcontextprotocol/go-sdk | v1.3.0 | v1.3.1 | bumped |
| google.golang.org/adk | v0.4.0 | v0.5.0 | skipped -- test failure (TestA2AServer_Invoke) |
| google.golang.org/genai | v1.46.0 | v1.47.0 | bumped |
ResolveModelAliases was mutating ModelConfig.Model in-place, replacing user-configured names (e.g., claude-haiku-4-5) with pinned API versions (e.g., claude-haiku-4-5-20251001). Since provider.ID() returned the mutated name, the sidebar displayed the resolved name instead of what the user wrote in their config. Add a DisplayModel field to ModelConfig that preserves the original name before alias resolution. Update provider.ID() (base and anthropic) to prefer DisplayModel when set. Remove the handleStream code that was rewriting the sidebar model name from the LLM API response. The API still uses the resolved/pinned model name for requests. Assisted-By: cagent
Assisted-By: cagent
Also upgrades aws-sdk-go-v2/credentials from v1.19.8 to v1.19.9 Assisted-By: cagent
Assisted-By: cagent
…o v0.0.0-20260219130522-0ba9a5494a59 Assisted-By: cagent
Assisted-By: cagent
Assisted-By: cagent
Assisted-By: cagent
Assisted-By: cagent
There was a problem hiding this comment.
Review Summary
This dependency update PR looks good! The code changes properly implement the DisplayModel field to preserve user-configured model names while using resolved aliases internally.
Changes Reviewed
- ✅ Dependency version bumps in go.mod/go.sum
- ✅ New DisplayModel field in ModelConfig with proper Clone() support
- ✅ DisplayOrModel() helper using safe fallback with cmp.Or
- ✅ Field exclusion from JSON serialization
- ✅ Model alias resolution logic updates
- ✅ ID() method refactoring across providers
No issues found. The implementation is clean and well-documented.
rumpl
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.