-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Build and publish v4 lib/ and themes/ folders for backwards compatibility while users transition to v5.
#2667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,9 @@ | |
| }, | ||
| "files": [ | ||
| "dist", | ||
| "src" | ||
| "src", | ||
| "lib", | ||
| "themes" | ||
| ], | ||
| "lint-staged": { | ||
| "*.js": "eslint --fix" | ||
|
|
@@ -93,8 +95,11 @@ | |
| "build:emoji": "node ./build/emoji.js", | ||
| "build:js": "rollup -c", | ||
| "build:types": "tsc", | ||
| "build:v4": "git checkout v4 && npm clean-install && git checkout docs/emoji.md src/core/render/emoji-data.js && rimraf packages/ && git checkout - && npm clean-install && npm run build:v4:deprecate -- lib/docsify.js && npm run build:v4:deprecate -- lib/docsify.min.js", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If version 5.0.0 is released, will the version in package.json update after checking out v4?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not quite sure what you mean here, let's chat on Discord so I'll get notified |
||
| "build:v4:deprecate": "echo ';console.warn(\"Docsify v4 is no longer supported. See https://docsify.js.org for the latest version.\")' >> ", | ||
| "build": "run-s clean build:types build:js build:css build:css:min build:cover", | ||
| "clean": "rimraf --glob \"dist/**\" \"themes/**\" \"_playwright*/**\" \"src/**/*.d.ts\" \"src/**/*.d.ts.map\"", | ||
| "clean": "rimraf --glob \"dist/**\" \"_playwright*/**\" \"src/**/*.d.ts\" \"src/**/*.d.ts.map\"", | ||
| "clean:v4": "rimraf lib/ themes/", | ||
| "dev": "run-p serve:dev watch:*", | ||
| "docker:build:test": "npm run docker:cli -- build:test", | ||
| "docker:build": "docker build -f Dockerfile -t docsify-test:local .", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sy-records now that release.sh is updated, can you try this out with a
--dryrun to verify it works? The dry run output will show which files would be published (without publishing).