Skip to content

chore: refactor child validation logic in useValidateChildren for improved clarity #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dorixdev merged 1 commit into from
Sep 5, 2025
Merged

chore: refactor child validation logic in useValidateChildren for improved clarity #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 23 additions & 30 deletions lib/hooks/useValidateChildren.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,43 +24,36 @@ export const useValidateChildren = ({ items, children }: UseValidateChildrenProp
const navKeys = new Set<string>();
const contentKeys = new Set<string>();

const isNav = (child: ReactNode) => isValidElement(child) && child.type === DualScrollSyncNav;
const collectNavKeys = (node: ReactNode) => {
if (isValidElement<DualScrollSyncNavItemProps>(node) && node.props.sectionKey) {
navKeys.add(node.props.sectionKey);
}
};

const isContent = (child: ReactNode) =>
isValidElement(child) && child.type === DualScrollSyncContent;
const collectContentKeys = (node: ReactNode) => {
if (isValidElement<DualScrollSyncContentSectionProps>(node) && node.props.sectionKey) {
contentKeys.add(node.props.sectionKey);
}
};

const visit = (node: ReactNode) => {
Children.forEach(node, (child) => {
if (!isValidElement(child)) return;

if (child.type === Fragment) {
visit((child.props as PropsWithChildren).children);
return;
}

if (isNav(child)) {
Children.forEach((child.props as PropsWithChildren).children, (navItem) => {
if (isValidElement<DualScrollSyncNavItemProps>(navItem) && navItem.props.sectionKey) {
navKeys.add(navItem.props.sectionKey);
switch (child.type) {
case Fragment:
visit((child.props as PropsWithChildren).children);
break;
case DualScrollSyncNav:
Children.forEach((child.props as PropsWithChildren).children, collectNavKeys);
break;
case DualScrollSyncContent:
Children.forEach((child.props as PropsWithChildren).children, collectContentKeys);
break;
default:
if ((child.props as PropsWithChildren)?.children) {
visit((child.props as PropsWithChildren).children);
}
});
return;
}

if (isContent(child)) {
Children.forEach((child.props as PropsWithChildren).children, (section) => {
if (
isValidElement<DualScrollSyncContentSectionProps>(section) &&
section.props.sectionKey
) {
contentKeys.add(section.props.sectionKey);
}
});
return;
}

if ((child.props as PropsWithChildren)?.children) {
visit((child.props as PropsWithChildren).children);
}
});
};
Expand Down